Issue 31: deserializing all fields in plain old mongo driver #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with mongo_session_store-rails4 5.1.0 version, mongo 1.12.3, rails 4.1.12. |
|
Thanks for the PR. I'm not prepared to merge this until more people report trouble. As mentioned in #31, this doesn't seem to happen with the Mongo 2 driver. I'm not prepared to fight with backwards compatibility at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserializing all fields in plain old mongo driver
It resolved issue 31 - there are no new document at every request (or they are removed).
No automatic tests written, tested only with with my application.
Unfortunately it still creates several documents for single session (in my case - three for ca. 10 requests).